Add more information in traces from GstTracer #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful in the logs to know the query/message/event that are being handled so we log them.
sdroege
reviewed
Jul 3, 2023
| @@ -91,6 +91,22 @@ fn state_desc(state: gstreamer::ffi::GstState) -> &'static str { | |||
| } | |||
| } | |||
|
|
|||
| fn query_name(query: &gstreamer::QueryRef) -> &'static str { | |||
There was a problem hiding this comment.
Why not use the proper bindings API for this but instead go via FFI?
There was a problem hiding this comment.
We do not expose that API yet? The only reference I found was in our fmt::Debug implementation which is clearly not what I want here. Should we add it?
There was a problem hiding this comment.
Opened https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1289 - I think this can be closed meanwhile.
There was a problem hiding this comment.
I think it is fine to keep this open and rebase later on. I don't consider open PRs to be a maintenance burden on repos with as low traffic as this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pad name in traces
Add pad chain infos
tracer: Factor out a SpanBuilder struct to log different objects
It is useful in the logs to know the query/message/event that are being
handled so we log them.
tracer: Log elements state change and messages on the bus %