Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6 and 8 argument overloads to wiener_lpdf #1411

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

WardBrian
Copy link
Member

From stan-dev/math#2822
Scalar only for now, see #1373 for partial reason

I didn't add support for the optional precision_derivatives argument both of these have in C++. These would need to be data, which we don't currently support in the machinery for our distributions. We can add them manually or rethink this later.

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here: TBD

Release notes

Exposed the new overloads of wiener_lpdf added to Stan Math by @Franzi2114

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

Scalar only for now, see #1373 for partial reason
@WardBrian WardBrian requested a review from SteveBronder March 18, 2024 14:29
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (8bc6ba0) to head (0ce17bf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1411   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          63       63           
  Lines       10525    10529    +4     
=======================================
+ Hits         9459     9463    +4     
  Misses       1066     1066           
Files Coverage Δ
src/middle/Stan_math_signatures.ml 98.02% <100.00%> (+<0.01%) ⬆️

@WardBrian WardBrian merged commit e162817 into master Mar 21, 2024
3 checks passed
@WardBrian WardBrian deleted the feature/wiener-overloads branch March 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants