-
-
Notifications
You must be signed in to change notification settings - Fork 192
Update hypergeometric_pFq to delegate to specialisations where relevant #3167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrjohns
wants to merge
4
commits into
develop
Choose a base branch
from
hypergeometric_pfq-delegate
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2896f60
Update hypergeometric_pFq to delegate to specialisations where relevant
andrjohns d61f515
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot 22d4541
Not 3F2 for now
andrjohns 66cfe21
Remove from central include
andrjohns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
#ifndef STAN_MATH_PRIM_FUN_HYPERGEOMETRIC_PFQ_HELPER_HPP | ||
#define STAN_MATH_PRIM_FUN_HYPERGEOMETRIC_PFQ_HELPER_HPP | ||
|
||
#include <stan/math/prim/meta.hpp> | ||
#include <stan/math/prim/fun/to_array_1d.hpp> | ||
#include <boost/math/special_functions/hypergeometric_pFq.hpp> | ||
|
||
namespace stan { | ||
namespace math { | ||
namespace internal { | ||
/** | ||
* Implementation for calculating the generalized hypergeometric function | ||
* \f$_pF_q(a_1,...,a_p;b_1,...,b_q;z)\f$. | ||
* | ||
* This is declared separatel to avoid circular dependencies between the | ||
* various hypergeometric functions. | ||
* | ||
* @param[in] a Vector of 'a' arguments to function | ||
* @param[in] b Vector of 'b' arguments to function | ||
* @param[in] z Scalar z argument | ||
* @return Generalized hypergeometric function | ||
*/ | ||
template <typename Ta, typename Tb, typename Tz, | ||
require_all_vector_st<std::is_arithmetic, Ta, Tb>* = nullptr, | ||
require_arithmetic_t<Tz>* = nullptr> | ||
inline double hypergeometric_pFq_helper(const Ta& a, const Tb& b, const Tz& z) { | ||
return boost::math::hypergeometric_pFq(to_array_1d(a), to_array_1d(b), z); | ||
} | ||
} // namespace internal | ||
} // namespace math | ||
} // namespace stan | ||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs for template parameters