Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON data files #226

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Add JSON data files #226

merged 7 commits into from
Feb 9, 2024

Conversation

WardBrian
Copy link
Member

This was done using cmdstanr::write_stan_json(rstan::read_rdump(file_R), file_json). The primary goal is to allow us to use these files in the cmdstan performance tests to avoid warnings about RDump, but they also serve as paired examples of the two data formats.

@WardBrian WardBrian requested a review from mitzimorris February 8, 2024 20:00
@mitzimorris
Copy link
Member

the method seems sound.
did you run the performance tests using the JSON data?

@WardBrian
Copy link
Member Author

I just ran them locally. They don't use all the models here (really only the ones in bugs_examples/ and regression_tests/), but seem just as happy with the new files as the old

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method is sound and has been tested locally - good enough for me!

@WardBrian WardBrian merged commit bd393fa into master Feb 9, 2024
1 check passed
@WardBrian WardBrian deleted the add-json-data-files branch February 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants