Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maplibre to v3.6.2 #190

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Update maplibre to v3.6.2 #190

merged 3 commits into from
Apr 8, 2024

Conversation

aparlato
Copy link
Collaborator

@aparlato aparlato commented Apr 8, 2024

Description

(Based on client specific ticket, will tag you there as well for context @ebrelsford )

This PR udpates MapLibre to the latest 3.x.x version to meet downstream client needs.

Looking at https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#potentially-breaking-changes, I believe the only breaking change that required addressing was around resizing the map which is done in this PR.

As followup we should look into the best way to implement #175. The alias approach makes sense, but won't account for breaking changes.

QA steps

  • Try out Maplibre maps and add, remove, and resize them to confirm normal behavior
  • Confirm Mapbox maps continue to have their previous normal resizing behavior as well

Author checklist

Create the PR

  • Fill out PR template
  • Make sure you've added a CHANGELOG entry under "Unreleased"
  • Request a review
  • Make any requested changes and get approval

After approval

  • Merge any changes from main into your branch, resolve any conflicts
  • Squash & merge changes into main
  • Delete branch

@aparlato aparlato requested a review from ebrelsford April 8, 2024 15:23
@@ -43,6 +43,7 @@
mapStyle: map,
numberOfMaps: num,
};
setMapComponent(mapRenderer);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this line for consistent prop being passed, since setProps gets called again and was making mapRenderer undefined.

@aparlato aparlato merged commit 4944620 into main Apr 8, 2024
@aparlato aparlato deleted the update-maplibre branch April 8, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants