Typeorm adapter improvements #36
Open
+191
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccatterina
force-pushed
the
typeorm-improvements-patch
branch
from
46a6112 to
6da689f
Compare
Add support for fields with nested relations (multiple levels) in the typeORM adapter. The other adapters treat these fields as simple fields and they don't join the relations. Fix issue stalniy#32 for TypeORM adapter.
Fix issue stalniy#25 for TypeORM adapter
Fix issue stalniy#26 for TypeORM adapter
There's no need to escape fields with typeorm querybuilder. Moreover field escaping can cause problems when an entity field name is different from the database field name.
ccatterina
force-pushed
the
typeorm-improvements-patch
branch
from
6da689f to
dbf2283
Compare
|
Hi, Thank you for the contribution. I will take a look at it but it will take some time |
|
👍 sure, np! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stalniy!
I've added some improvements to typeorm adapter.
We have been using a version of ucast with these changes in our application for a few months now and it seems to work fine.
I opened a single PR with all the improvements split in different commits, let me know if you prefer separated PRs.