Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#582] Allow to use auto annotation with specific resource type (configmap or secret) #604

Merged
merged 4 commits into from
Apr 8, 2024
Merged

[#582] Allow to use auto annotation with specific resource type (configmap or secret) #604

merged 4 commits into from
Apr 8, 2024

Conversation

kichel98
Copy link

@github-actions GitHub Actions
Copy link

@kichel98 Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-bccefb16\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-UBI-bccefb16

@kichel98 kichel98 marked this pull request as ready for review January 19, 2024 14:58
@kichel98 kichel98 mentioned this pull request Jan 19, 2024
Closed
@github-actions GitHub Actions
Copy link

@kichel98 Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-98905388\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-UBI-98905388

@MuneebAijaz MuneebAijaz self-requested a review January 31, 2024 09:02
@github-actions GitHub Actions
Copy link

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-b4fe7fb1\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-UBI-b4fe7fb1

@FUSAKLA
Copy link

FUSAKLA commented Apr 4, 2024

Hi, we would like this feature as well, is there anything blocking this PR or is there anything we can help do to get this merged? 🙏

@kichel98
Copy link
Author

kichel98 commented Apr 4, 2024

@FUSAKLA It was prepared from my side, the PR was just waiting for review.

@MuneebAijaz Any changes to look at this?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

@MuneebAijaz Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-1cae7a03\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-604-UBI-1cae7a03

@MuneebAijaz
Copy link
Contributor

@kichel98 apologies for the delay.

MuneebAijaz
MuneebAijaz approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@MuneebAijaz MuneebAijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MuneebAijaz MuneebAijaz merged commit 4c42681 into stakater:master Apr 8, 2024
5 checks passed
@MuneebAijaz MuneebAijaz linked an issue Apr 8, 2024 that may be closed by this pull request
[ENHANCE] Allow to use auto annotation with specific resource type (configmap or secret) #582
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuneebAijaz MuneebAijaz MuneebAijaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCE] Allow to use auto annotation with specific resource type (configmap or secret)
4 participants
@kichel98 @FUSAKLA @MuneebAijaz @karl-johan-grahn