refactor(alert): adapt alert handling to upstream #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreashelms
reviewed
Dec 4, 2024
| @@ -467,7 +439,7 @@ class RoutePageControlPanel extends React.Component { | |||
| <FormattedMessage id="route-guide" defaultMessage="Route guide" /> | |||
| </h1> | |||
| </div> | |||
| {isOnDemandTaxi && <CallAgencyWarning route={route} />} | |||
| {route.type === 715 && <CallAgencyWarning route={route} />} | |||
There was a problem hiding this comment.
I think we should keep isOnDemandTaxi here to point out when this warning is displayed.
const isOnDemandTaxi = route.type === 715;
andreashelms
requested changes
Dec 4, 2024
|
Thanks, there were indeed some changes missing... |
andreashelms
approved these changes
Dec 4, 2024
hbruch
force-pushed
the
alerts-upstream-merge
branch
from
f092457 to
401cc5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies upstream changes regarding alerts handling and display.
Besides this, for TimeStore the upstream change to return the unix timestamp instead of moment has been ported.