Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

229: remove unused contract #241

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

blockgroot
Copy link
Contributor

Resolves #229

@blockgroot blockgroot self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (bd7e239) to head (89fbdef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   89.11%   89.49%   +0.38%     
==========================================
  Files          42       41       -1     
  Lines        2553     2542      -11     
  Branches      298      297       -1     
==========================================
  Hits         2275     2275              
+ Misses        194      183      -11     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blockgroot blockgroot force-pushed the refactor/remove-unused-contracts branch from eacea6f to f979961 Compare June 19, 2024 15:18
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This code is now managed on https://github.com/stader-labs/ethx_oft

@blockgroot blockgroot merged commit 6ad9ef1 into main Jun 20, 2024
7 of 8 checks passed
@blockgroot blockgroot deleted the refactor/remove-unused-contracts branch June 20, 2024 05:31
blockgroot added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OFTAdapter changes: Remove L2/ETHx.sol
2 participants