fix: call internal function and allow manager to grant and revoke per…

…missions
stader-labs · Oct 3, 2024 · 0dbfe22 · 0dbfe22
1 parent 73a1415
commit 0dbfe22
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/contracts/StaderConfig.sol b/contracts/StaderConfig.sol
@@ -302,19 +302,19 @@ contract StaderConfig is IStaderConfig, AccessControlUpgradeable {
         address contractAddress,
         string calldata functionSig,
         address accountToPermit
-    ) external onlyRole(DEFAULT_ADMIN_ROLE) {
+    ) external onlyRole(MANAGER) {
         bytes32 role = keccak256(abi.encodePacked(contractAddress, functionSig));
-        grantRole(role, accountToPermit);
+        _grantRole(role, accountToPermit);
         emit PermissionGranted(accountToPermit, contractAddress, functionSig);
     }
 
     function revokeCallPermission(
         address contractAddress,
         string calldata functionSig,
         address accountToRevoke
-    ) external onlyRole(DEFAULT_ADMIN_ROLE) {
+    ) external onlyRole(MANAGER) {
         bytes32 role = keccak256(abi.encodePacked(contractAddress, functionSig));
-        revokeRole(role, accountToRevoke);
+        _revokeRole(role, accountToRevoke);
         emit PermissionRevoked(accountToRevoke, contractAddress, functionSig);
     }
 

diff --git a/test/foundry_tests/SDRewardsManager.t.sol b/test/foundry_tests/SDRewardsManager.t.sol
@@ -16,6 +16,7 @@ import { IERC20Upgradeable } from "@openzeppelin/contracts-upgradeable/token/ERC
 
 contract SDRewardManagerTest is Test {
     address staderAdmin;
+    address staderManager;
     address user1;
     address user2;
     address staderTokenDeployer;
@@ -35,6 +36,7 @@ contract SDRewardManagerTest is Test {
         user2 = vm.addr(102);
         staderTokenDeployer = vm.addr(103);
         address ethDepositAddr = vm.addr(104);
+        staderManager = vm.addr(105);
 
         vm.prank(staderTokenDeployer);
         staderToken = new StaderTokenMock();
@@ -70,7 +72,11 @@ contract SDRewardManagerTest is Test {
 
         vm.startPrank(staderAdmin);
         staderConfig.updateStaderToken(address(staderToken));
+        staderConfig.grantRole(staderConfig.MANAGER(), staderManager);
         staderConfig.updatePermissionlessSocializingPool(address(permissionlessSP));
+        vm.stopPrank();
+
+        vm.startPrank(staderManager);
         staderConfig.giveCallPermission(address(rewardManager), "addRewardEntry(uint256,uint256)", user1);
         staderConfig.giveCallPermission(address(rewardManager), "approveEntry(uint256)", user1);
         vm.stopPrank();