fixing lint issue, add test for 6% protocol fee, 4% operator #984
jac18281828Annotations
11 warnings
|
Run linters
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run linters
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run linters:
contracts/PermissionedNodeRegistry.sol#L21
Contract has 19 states declarations but allowed no more than 15
|
|
Run linters:
contracts/PermissionedNodeRegistry.sol#L627
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Run linters:
contracts/PermissionlessNodeRegistry.sol#L24
Contract has 18 states declarations but allowed no more than 15
|
|
Run linters:
contracts/PermissionlessNodeRegistry.sol#L558
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Run linters:
contracts/ProxyAdmin.sol#L4
imported name ProxyAdmin is not used
|
|
Run linters:
contracts/SDUtilityPool.sol#L18
Contract has 25 states declarations but allowed no more than 15
|
|
Run linters:
contracts/StaderConfig.sol#L72
Constant name must be in capitalized SNAKE_CASE
|
|
Run linters:
contracts/StaderOracle.sol#L20
Contract has 22 states declarations but allowed no more than 15
|
|
Run linters:
contracts/VaultProxy.sol#L40
Fallback function must be simple
|