Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use fsspec #6

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

sharkinsspatial
Copy link
Contributor

Before you submit a pull request, please fill in the following:

Related Issue(s):
Closes #5
Closes #3

Description:
Updated the package to use the normal fsspec io pattern used by all other stactools packages.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

Copy link
Collaborator

@emileten emileten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the example data files as we no longer need them, and switched to using the URL in the tests and examples, instead.

…d example, change arg name to make it clear were using remote hrefs
@emileten emileten merged commit 97ce6ba into stactools-packages:main Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fsspec for io Avoid reading from the HDF5 file.
2 participants