-
Notifications
You must be signed in to change notification settings - Fork 696
Update blockchain-team to blockchain-team-reviewers #6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wileyj
wants to merge
2
commits into
stacks-network:develop
Choose a base branch
from
wileyj:chore/update_codeowners
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,10 @@ | ||
| # These owners will be the default owners for everything in | ||
| # the repo. Unless a later match takes precedence, | ||
| # | ||
| # require both blockchain-team-codeowners and blockchain-team to review all PR's not specifically matched below | ||
| * @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team | ||
|
|
||
|
|
||
| # Signer code | ||
| # require both blockchain-team-codeowners and blockchain-team-signer to review PR's for the signer folder(s) | ||
| libsigner/**/*.rs @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team-signer | ||
| stacks-signer/**/*.rs @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team-signer | ||
| # require both blockchain-team-codeowners and blockchain-team-reviewers to review all PR's not specifically matched below | ||
| * @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team-reviewers | ||
|
|
||
| # CI workflows | ||
| # require both blockchain-team and blockchain-team-ci teams to review PR's modifying CI workflows | ||
| /.github/workflows/ @stacks-network/blockchain-team @stacks-network/blockchain-team-ci | ||
| /.github/actions/ @stacks-network/blockchain-team @stacks-network/blockchain-team-ci | ||
| # require both blockchain-team-ci and blockchain-team-reviewers teams to review PR's modifying CI workflows | ||
| /.github/workflows/ @stacks-network/blockchain-team-ci @stacks-network/blockchain-team-reviewers | ||
| /.github/actions/ @stacks-network/blockchain-team-ci @stacks-network/blockchain-team-reviewers | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I think it means Aaron / Brice / Jude won't count as valid approvals, which wouldn't be what we want right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for these specific files, i didn't think they should be required since this path isn't blockchain/code specific - it mainly pertains to CI changes. we can definitely require their review here if you want though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and to be verbose - their review would still count towards the total reviews required, but not as a required codeowner for this path.