Skip to content

Feat/signer two phase commit #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented May 5, 2025

No description provided.

@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch 2 times, most recently from 3156089 to c7dc731 Compare May 5, 2025 22:29
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch from c7dc731 to 05285b2 Compare May 6, 2025 00:48
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 75.68389% with 80 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (1f833be) to head (9bb9f9c).
Report is 51 commits behind head on develop.

Files with missing lines Patch % Lines
testnet/stacks-node/src/tests/signer/v0.rs 32.65% 66 Missing ⚠️
stacks-signer/src/v0/signer.rs 90.76% 12 Missing ⚠️
libsigner/src/v0/messages.rs 85.71% 1 Missing ⚠️
stacks-signer/src/signerdb.rs 98.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6082      +/-   ##
===========================================
- Coverage    83.71%   83.43%   -0.28%     
===========================================
  Files          538      538              
  Lines       388438   388736     +298     
  Branches       323      323              
===========================================
- Hits        325172   324343     -829     
- Misses       63258    64385    +1127     
  Partials         8        8              
Files with missing lines Coverage Δ
stacks-signer/src/monitoring/mod.rs 91.66% <100.00%> (+0.26%) ⬆️
stacks-signer/src/monitoring/prometheus.rs 100.00% <ø> (ø)
stacks-signer/src/v0/tests.rs 89.42% <100.00%> (-3.84%) ⬇️
...tacks-node/src/nakamoto_node/stackerdb_listener.rs 83.98% <100.00%> (+0.04%) ⬆️
libsigner/src/v0/messages.rs 87.41% <85.71%> (+0.18%) ⬆️
stacks-signer/src/signerdb.rs 94.36% <98.66%> (+0.12%) ⬆️
stacks-signer/src/v0/signer.rs 84.75% <90.76%> (-1.33%) ⬇️
testnet/stacks-node/src/tests/signer/v0.rs 56.08% <32.65%> (-3.90%) ⬇️

... and 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45867c...9bb9f9c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant