removing deprecated puppet-chain and relay-server from contrib folder #6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
moving to draft - needs a little more work |
…ntrib * upstream/develop: (38 commits) Fix typo in function def CRC: pass block info as an optonal to send_block_response_impl Remove duplicate code when sending block responses fix: cargo check --tests warning address PR comments (6081) move CODEOWNERS and adjust requirements to automatically add multiple teams to reviews add index for processable_block in staging_blocks fix entry block-id/hash cache refactor perf: do not read whole snapshot for ancestor check in find_new_block_arrivals remove release build arg build all binaries in core build workflow crc: remove chrono dependency, stacks-network#5918 Add missing import for SUPPORTED_SIGNER_PROTOCOL_VERSION crc: remove system time utility functions, stacks-network#5918 crc: fix record_signer_agreement_capitulation_latency documentation, stacks-network#5918 fix: mock miner should continue mining throughout tenure Remove testing assert from debugging Remove use of macro Add deserializer for custom blockstack op fields and make sure backwards compatibility satisfied for TransactionEventPayload CRC: typo in unreachable message ...
|
obycode
approved these changes
May 7, 2025
Yes - that's because i'm not 100% certain if they are deprecated, but i think they are/should be. I opened this PR with intention of closing it in case those binaries are still useful, but i can't find any use case today (puppet-chain is still defined in the net-test test, which hasn't been used in a while). the codebase of each tool hasn't been updated in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes possibly deprecated
./contrib/tools/{puppet-chain, relay-server}folderscloses #6067