-
Notifications
You must be signed in to change notification settings - Fork 696
state machine updates for tx replay #6020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
state machine updates for tx replay #6020
Conversation
…o feat/fork-detection-state-machine
Current state of this PR:
|
…ransactions Signed-off-by: Jacinta Ferrant <[email protected]>
I've updated this PR with an additional test scenario that tests forked txs across multiple tenures, which caught an issue regarding the order of the replay set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just a few comments
All comments addressed, plz re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixed a conflict, re-requesting reviews 🙏 |
This PR implements:
Vec<StacksTransaction>
in state machine updatesThis builds on top of #6048 (which we should merge first)