Skip to content

chore: document BurnchainConfig parameters #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025

Conversation

Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Apr 13, 2025

Description

Add documentation for all BurnchainConfig parameters

Applicable issues

second step of #5898

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc requested a review from a team as a code owner April 13, 2025 16:29
@Jiloc Jiloc changed the title add BurnchainConfig documentation chore: document BurnchainConfig parameters Apr 13, 2025
@Jiloc Jiloc self-assigned this Apr 13, 2025
@Jiloc Jiloc requested review from obycode and wileyj April 13, 2025 17:46
@wileyj wileyj self-requested a review May 1, 2025 14:48
@aldur aldur moved this to Status: In Review in Stacks Core Eng May 2, 2025
@aldur aldur added this to the 3.1.0.0.9 milestone May 2, 2025
@aldur aldur modified the milestones: 3.1.0.0.9, 3.1.0.0.10 May 6, 2025
@aldur aldur requested review from kantai and wileyj May 6, 2025 14:50
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just also commented this on #6000: would it make more sense to have these detailed comments on BurnchainConfigFile and an abbreviated version on BurnchainConfig? The ...File variants are the ones that need the really good documentation. Maybe we should work to merge these two versions of all of these config structs?

@wileyj
Copy link
Collaborator

wileyj commented May 7, 2025

I just also commented this on #6000: would it make more sense to have these detailed comments on BurnchainConfigFile and an abbreviated version on BurnchainConfig? The ...File variants are the ones that need the really good documentation. Maybe we should work to merge these two versions of all of these config structs?

related? #6085

@obycode
Copy link
Contributor

obycode commented May 7, 2025

So that these comments can be easily extracted into documentation for the config file, I'd recommend that all references to other fields just use the field name, without the struct prefix, e.g. "[BurnchainConfig::mode]" should just be "mode".

@obycode
Copy link
Contributor

obycode commented May 7, 2025

I just also commented this on #6000: would it make more sense to have these detailed comments on BurnchainConfigFile and an abbreviated version on BurnchainConfig? The ...File variants are the ones that need the really good documentation. Maybe we should work to merge these two versions of all of these config structs?

Per discussion in the Nakamoto sync, let's leave the comments as-is for now, and in a separate issue, we will work on merging the two versions of the config structs.

@aldur aldur requested review from obycode, wileyj and fdefelici May 14, 2025 14:35
wileyj
wileyj previously approved these changes May 14, 2025
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just added some minor nits

fdefelici
fdefelici previously approved these changes May 15, 2025
Co-authored-by: Federico De Felici <[email protected]>
@Jiloc Jiloc dismissed stale reviews from fdefelici and wileyj via ae6e091 May 15, 2025 10:33
@Jiloc Jiloc requested a review from a team as a code owner May 15, 2025 10:33
@Jiloc Jiloc requested a review from wileyj May 15, 2025 12:28
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng May 15, 2025
@Jiloc Jiloc added this pull request to the merge queue May 15, 2025
Merged via the queue into stacks-network:develop with commit 5719fa7 May 15, 2025
208 of 211 checks passed
@Jiloc Jiloc deleted the chore/document-burnchain-config branch May 15, 2025 16:23
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (aab7784) to head (ae6e091).
Report is 306 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/config/mod.rs 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (72.36%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (aab7784) and HEAD (ae6e091). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (aab7784) HEAD (ae6e091)
150 135
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6005       +/-   ##
============================================
- Coverage    84.10%   72.36%   -11.74%     
============================================
  Files          528      542       +14     
  Lines       385675   389885     +4210     
  Branches       323      323               
============================================
- Hits        324355   282157    -42198     
- Misses       61312   107720    +46408     
  Partials         8        8               
Files with missing lines Coverage Δ
stackslib/src/config/mod.rs 62.50% <0.00%> (-10.88%) ⬇️

... and 311 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e304a...ae6e091. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants