-
Notifications
You must be signed in to change notification settings - Fork 696
chore: document BurnchainConfig parameters #6005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: document BurnchainConfig parameters #6005
Conversation
Co-authored-by: wileyj <[email protected]>
Co-authored-by: wileyj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just also commented this on #6000: would it make more sense to have these detailed comments on BurnchainConfigFile
and an abbreviated version on BurnchainConfig
? The ...File
variants are the ones that need the really good documentation. Maybe we should work to merge these two versions of all of these config structs?
related? #6085 |
So that these comments can be easily extracted into documentation for the config file, I'd recommend that all references to other fields just use the field name, without the struct prefix, e.g. "[ |
Per discussion in the Nakamoto sync, let's leave the comments as-is for now, and in a separate issue, we will work on merging the two versions of the config structs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just added some minor nits
Co-authored-by: Federico De Felici <[email protected]>
5719fa7
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (72.36%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6005 +/- ##
============================================
- Coverage 84.10% 72.36% -11.74%
============================================
Files 528 542 +14
Lines 385675 389885 +4210
Branches 323 323
============================================
- Hits 324355 282157 -42198
- Misses 61312 107720 +46408
Partials 8 8
... and 311 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
Add documentation for all
BurnchainConfig
parametersApplicable issues
second step of #5898
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml