feat/SIP-029 #5461
Draft
feat/SIP-029 #5461
+951
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
N.B. This will require a block replay test to verify that it works. A genesis sync may be overkill. |
|
This PR will be noted in the "Reference Implementation" section of SIP-029 (here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proposed emissions schedule in SIP-029. It does so by way of introducing
StacksEpochId::Epoch31, and all of the necessary changes therein (e.g. block-commit memo bump, peer version bump, etc.).This PR moves the coinbase calculation logic into
StacksEpochId, and out ofStacksChainState. This is done to make epoch-gating slightly easier. It also adds a means by which unit and integration tests can override the coinbase schedule, which will allow us to test it on a shorter timescale with confidence.I'm opening this against
developbecause it's backwards-compatible. The rules don't go into effect until Bitcoin height 875,000.I'm leaving this as a draft until I can get an integration test in place which tests the new coinbase emissions logic.