-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/signer track validation submission with config timeout #5409
Feat/signer track validation submission with config timeout #5409
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
…f we already are processing one Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-track-validation-submission-with-config-timeout
I'm a little wary of this change -- if the stacks-node is slow to respond to a block proposal, returning a rejection from the signer doesn't necessarily improve performance: the stacks-node is still going to be working on that proposal, and so the signer isn't really free to consider other proposals at that point. |
Probably a good point - would it be better to have the timeout on the stacks-node? |
Yeah, that's a good idea. When processing requests, if it sees a block validation request from greater than X seconds ago (may need to add a timestamp in the request), quickly respond with an error code so the node doesn't spend any time doing the validation if the block is already too old. But should the signer still have some mechanism to timeout if the node never responds? What if the node crashed and restarted and the request was dropped? |
I have created a ticket for this #5439 |
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-track-validation-submission-with-config-timeout
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-track-validation-submission-with-config-timeout
… into feat/signer-track-validation-submission-with-config-timeout
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-track-validation-submission-with-config-timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #5408