-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tenure-height to the /v2/info endpoint #5308
Conversation
Moved to draft as I investigate test failures. |
Don't worry about these failing test cases. There is another PR open to fix the mock-mining test. |
Thanks @obycode! If it's OK not to worry about mutants either (AFAICT they were missing before), this is ready for review. |
Yup, we are not enforcing the mutants checks yet and can expect failures on that. |
Co-authored-by: Aaron Blankstein <[email protected]>
Co-authored-by: Aaron Blankstein <[email protected]>
Thanks @kantai! I rebased on latest |
Thanks @jcnelson, I took the approach you suggested and cached the |
I was asked to add a test here. Addressing code comments and adding test now. |
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for carrying this over the finish line @jferrant!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
#5304 looked simple enough for me to give it a shot.
I have used this one for the definition of
tenure-height
.Applicable issues
tenure-height
to the /v2/info endpoint #5304.Additional info (benefits, drawbacks, caveats)
NA
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)New clarity functions have corresponding PR inclarity-benchmarking
repoNew integration test(s) added tobitcoin-tests.yml