Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tenure-height to the /v2/info endpoint #5308

Merged
merged 17 commits into from
Oct 17, 2024
Merged

feat: Add tenure-height to the /v2/info endpoint #5308

merged 17 commits into from
Oct 17, 2024

Conversation

aldur
Copy link
Contributor

@aldur aldur commented Oct 14, 2024

Description

#5304 looked simple enough for me to give it a shot.

I have used this one for the definition of tenure-height.

Applicable issues

Additional info (benefits, drawbacks, caveats)

NA

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@aldur aldur requested review from a team as code owners October 14, 2024 11:41
@aldur aldur requested a review from a team as a code owner October 14, 2024 11:42
@aldur aldur marked this pull request as draft October 14, 2024 13:32
@aldur
Copy link
Contributor Author

aldur commented Oct 14, 2024

Moved to draft as I investigate test failures.

@obycode
Copy link
Contributor

obycode commented Oct 14, 2024

Don't worry about these failing test cases. There is another PR open to fix the mock-mining test.

@aldur aldur marked this pull request as ready for review October 14, 2024 16:25
@aldur
Copy link
Contributor Author

aldur commented Oct 14, 2024

Thanks @obycode! If it's OK not to worry about mutants either (AFAICT they were missing before), this is ready for review.

@obycode
Copy link
Contributor

obycode commented Oct 14, 2024

Thanks @obycode! If it's OK not to worry about mutants either (AFAICT they were missing before), this is ready for review.

Yup, we are not enforcing the mutants checks yet and can expect failures on that.

@aldur
Copy link
Contributor Author

aldur commented Oct 16, 2024

Thanks @kantai! I rebased on latest develop, spread your caching suggestion on another file, and applied the other one on the parser.

@aldur
Copy link
Contributor Author

aldur commented Oct 17, 2024

Thanks @jcnelson, I took the approach you suggested and cached the coinbase_height. I have pushed the work so far, but the caching layer needs tests.

stackslib/src/net/p2p.rs Outdated Show resolved Hide resolved
stackslib/src/net/p2p.rs Outdated Show resolved Hide resolved
stackslib/src/net/p2p.rs Outdated Show resolved Hide resolved
@jferrant
Copy link
Collaborator

I was asked to add a test here. Addressing code comments and adding test now.

Signed-off-by: Jacinta Ferrant <[email protected]>
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for carrying this over the finish line @jferrant!

@saralab saralab added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 1c9596c Oct 17, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants