Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update to use core tap #176

Merged
merged 1 commit into from
Jul 15, 2024
Merged

docs: update to use core tap #176

merged 1 commit into from
Jul 15, 2024

Conversation

chenrui333
Copy link
Contributor

👋 now we have included into the core tap, might be good to update to use it. :)

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

memark
memark approved these changes Jul 14, 2024
View reviewed changes
Copy link

@memark memark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAORMX JAORMX merged commit 0c74f2d into stacklok:main Jul 15, 2024
7 checks passed
@coveralls
Copy link

Coverage Status

coverage: 52.747%. remained the same
when pulling 1eff5a0 on chenrui333:patch-3
into d909251 on stacklok:main.

@chenrui333 chenrui333 deleted the patch-3 branch July 15, 2024 18:04
@BrewTestBot BrewTestBot mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

@memark memark memark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenrui333 @CLAassistant @coveralls @JAORMX @memark