Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better functionality to secret detection #937

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Conversation

yrobla
Copy link
Contributor

@yrobla yrobla commented Feb 5, 2025

add the following functionality:

  • improve regexes for identificating secrets via patterns
  • add high entropy secret detection
  • include the key of the secret in the found matches

Closes: #209

@yrobla yrobla force-pushed the issue-209 branch 3 times, most recently from 933721b to da37d1e Compare February 6, 2025 10:43
@yrobla yrobla requested review from aponcedeleonch, jhrozek, JAORMX and lukehinds and removed request for aponcedeleonch February 6, 2025 10:56
prompts/default.yaml Outdated Show resolved Hide resolved
add the following functionality:
- improve regexes for identificating secrets via patterns
- add high entropy secret detection
- include the key of the secret in the found matches

Closes: #209
aponcedeleonch
aponcedeleonch previously approved these changes Feb 6, 2025
Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yrobla yrobla merged commit ecdc2e2 into main Feb 6, 2025
9 checks passed
@yrobla yrobla deleted the issue-209 branch February 6, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assess fidelity of secret pattern matching
3 participants