Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish errors and miscelaneous fixes for workspaces #649

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jan 20, 2025

This raises specific errors which are then handled excplicitly. Thus
giving us more detailed error messages.

Signed-off-by: Juan Antonio Osorio [email protected]

@JAORMX JAORMX requested review from aponcedeleonch and alex-mcgovern and removed request for aponcedeleonch January 20, 2025 08:33
@JAORMX JAORMX force-pushed the exceptions-workspace-activate branch from 3865dc1 to e449357 Compare January 20, 2025 08:43
This raises specific errors which are then handled excplicitly. Thus
giving us more detailed error messages.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX force-pushed the exceptions-workspace-activate branch from e449357 to 263ec0c Compare January 20, 2025 08:53
Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX changed the title Polish errors in workspace activation Polish errors and miscelaneous fixes for workspaces Jan 20, 2025
Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JAORMX JAORMX merged commit b78c6d9 into stacklok:main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants