feat: properly fix permissions on image #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Dec 4, 2024
| @@ -30,14 +30,19 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # Create a non-root user and switch to it | |||
| RUN adduser --system --no-create-home codegate --uid 1000 | |||
| RUN useradd -rm -d /home/codegate -s /bin/bash -g root -G sudo -u 1001 codegate | |||
There was a problem hiding this comment.
FYI, useradd and adduser are equivalents. I'll ack if this moves us forward, but as a general comment I don't understand why we need sudo and why we need the root group.
There was a problem hiding this comment.
Having documentation about the need for sudo and the root group would be ideal. I would have flagged this as a potential vuln, actually.
There was a problem hiding this comment.
let's hold for now. I needed that because i was hacking the backup/restore of weaviate_data folder for backup. But i am working on proper backup/restore methods
jhrozek
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.