-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support muxing rules #311
Conversation
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
@danbarr could you take a look to this PR, I would like to have your feedback on this? |
Thanks @peppescg
|
Pull Request Test Coverage Report for Build 13328630689Details
💛 - Coveralls |
src/features/workspace/components/__tests__/workspace-muxing-model.test.tsx
Outdated
Show resolved
Hide resolved
src/features/workspace/components/workspace-models-dropdown.tsx
Outdated
Show resolved
Hide resolved
model: modelName, | ||
provider_id, | ||
}) | ||
setIsOpen(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-mcgovern same question as always 🤔
I guess in this case it's a bit more tricky, but should we try to avoid the controlled state here somehow?
Add Muxing rules support:
Kapture.2025-02-13.at.21.08.57.mp4
Remove old queries
We had an issue caused byt the fact that after rename the workspace name we didn't remove the old staled query based on the old workspace name, this caused an API fetch with old workspace name that return a 404 for custom-instructions and muxing.
I created a util func that received as input the queryClient and a list of queriesFns removing all the old queries after the workspace name mutation.
BEFORE
Kapture.2025-02-13.at.11.40.12.mp4
AFTER
Kapture.2025-02-13.at.11.41.04.mp4