This repository was archived by the owner on Jul 8, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add support muxing rules #311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
@danbarr could you take a look to this PR, I would like to have your feedback on this? |
Thanks @peppescg
|
Pull Request Test Coverage Report for Build 13328630689Details
💛 - Coveralls |
danbarr
reviewed
Feb 13, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
src/features/workspace/components/__tests__/workspace-muxing-model.test.tsx
Outdated
Show resolved
Hide resolved
kantord
reviewed
Feb 14, 2025
src/features/workspace/components/workspace-models-dropdown.tsx
Outdated
Show resolved
Hide resolved
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
model: modelName, | ||
provider_id, | ||
}) | ||
setIsOpen(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-mcgovern same question as always 🤔
I guess in this case it's a bit more tricky, but should we try to avoid the controlled state here somehow?
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
kantord
reviewed
Feb 14, 2025
alex-mcgovern
approved these changes
Feb 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Muxing rules support:
Kapture.2025-02-13.at.21.08.57.mp4
Remove old queries
We had an issue caused byt the fact that after rename the workspace name we didn't remove the old staled query based on the old workspace name, this caused an API fetch with old workspace name that return a 404 for custom-instructions and muxing.
I created a util func that received as input the queryClient and a list of queriesFns removing all the old queries after the workspace name mutation.
BEFORE
Kapture.2025-02-13.at.11.40.12.mp4
AFTER
Kapture.2025-02-13.at.11.41.04.mp4