INFRA-709 Rated dwpd alerts #1077
Merged
+2,177
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovial
reviewed
May 28, 2024
technowhizz
force-pushed
the
rated-dwpd-alerts
branch
from
c3561f1 to
16cb223
Compare
dougszumski
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Excellent piece of work @technowhizz . Please see if you can simplify it by writing out the DWPD file separately. Unless I've missed something?
|
@technowhizz what do we need to do to get this moving again? It looks like a lot of work and I don't want it to go to waste |
Now we have started on the Python script it makes sense to finish that first and then come back to this. |
Alex-Welsh
added
enhancement
technowhizz
force-pushed
the
rated-dwpd-alerts
branch
from
16cb223 to
65b5556
Compare
technowhizz
force-pushed
the
rated-dwpd-alerts
branch
from
65b5556 to
fe38209
Compare
|
I need to update the release note |
|
@technowhizz could you resolve the linter issues so we can try and get this merged? It's been stuck for a while |
technowhizz
force-pushed
the
rated-dwpd-alerts
branch
7 times, most recently
from
3476cc7 to
185ba2d
Compare
technowhizz
force-pushed
the
rated-dwpd-alerts
branch
from
3ebdc25 to
4c0f79a
Compare
dougszumski
reviewed
Jun 5, 2025
dougszumski
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the operator to specify the rated DWPD of a disk and have it show up in prometheus