Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sndev cleanup #1563

Merged
merged 5 commits into from
Nov 9, 2024
Merged

sndev cleanup #1563

merged 5 commits into from
Nov 9, 2024

Conversation

huumn
Copy link
Member

@huumn huumn commented Nov 9, 2024

closes #1533

You'll have to delete and restart containers after this is merged. It renames stacker_(lnd|cln) to (lnd|cln) and relies on docker compose labels to provide access to service clis/onions/certs now.

This replaces:

  • sndev fund_user -> sndev set_balance
  • sndev (stacker|sn)_(lndcli|clncli|litcli) -> sndev cli (lnd|sn_lnd|cln|litd)
  • sndev (stacker_(lnd|cln)|lnbits) get_onion -> sndev onion (lnd|cln|lnbits)
  • sndev stacker_lnd get_cert -> sndev cert lnd
  • sndev (fund|withdraw)_cln -> sndev (fund|withdraw) --cln

This adds:

  • sndev test command (which just runs our one jest test)

@riccardobl
Copy link
Member

riccardobl commented Nov 9, 2024

This is unrelated to the pr, but i've noticed that some sndev commands do not work in my ubuntu workstation if i run it with ./sndev. The cause seems to be the use of bash conditional expressions [[ ]] that are not supported by the real /bin/sh (even though /bin/sh might be a symlink to /bin/bash in some distro).

Imo for correctness we should use the shebang #!/bin/bash , if it doesn't cause issues in other OSes

@huumn
Copy link
Member Author

huumn commented Nov 9, 2024

That's weird because it passed the shellcheck check job we run on prs.

@huumn
Copy link
Member Author

huumn commented Nov 9, 2024

Ah it's not catching that problem because it's just a warning. I'll fix that in this pr. I think I added a few more of those bash syntax conditionals.

@huumn
Copy link
Member Author

huumn commented Nov 9, 2024

Should be fixed. There was just one usage of [[ COND ]] in fund_user (now set_balance).

@huumn huumn merged commit 4675a2c into master Nov 9, 2024
6 checks passed
@huumn huumn deleted the sndev-cleanup branch November 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor sndev to have fewer commands
2 participants