Implement optional overlay on top of the spot #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruibinch
commented
Dec 21, 2023
| {spotOverlayProps && | ||
| <ShapeMask | ||
| spot={spot} | ||
| setReference={refs.setReference} |
There was a problem hiding this comment.
Not 100% sure on the use case of setReference, maybe could be removed for this overlay
|
@ruibinch, sorry for the late response. I'm glad you're finding this package helpful! I'm not sure if I understood the use case correctly. The idea is to have:
We can easily achieve option b) if we invert the colors of the SVG mask. However, for option a), we have to render and animate an additional shape on top of the mask (current solution). Let me know if option b) covers your use case. Otherwise, we can go with the current approach, but we'll need to make a few adjustments. Thanks a lot for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using this package at work and there was an additional use case to have an overlay on top of the "spotlight area" to improve the contrast with the background - I made a patch file to support this and figured to open a PR here too.
Thanks for this great package!