Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(kuttl): Remove the -o pipefail bash option #535

Merged
merged 1 commit into from
Sep 3, 2024
Merged

test(kuttl): Remove the -o pipefail bash option #535

merged 1 commit into from
Sep 3, 2024

Conversation

NickLarsenNZ
Copy link
Member

Kuttl hard codes sh -c, instead of allowing alternative shells to be used.
For now, we need to drop the -o pipefail option.

See: kudobuilder/kuttl#557

Note

For zsh users, sh appears to just alias zsh, so locally set -euo pipfail worked fine.

@NickLarsenNZ NickLarsenNZ self-assigned this Sep 3, 2024
maltesander
maltesander approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 05efa8a Sep 3, 2024
31 checks passed
@NickLarsenNZ NickLarsenNZ deleted the kuttl-remove-pipefail branch September 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @maltesander