Skip to content

fix(spark-k8s): refactor for Spark Connect #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 28, 2025
Merged

fix(spark-k8s): refactor for Spark Connect #1034

merged 16 commits into from
Mar 28, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Mar 21, 2025

Description

Part of: stackabletech/spark-k8s-operator#284

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan changed the title fix(spark): JAVA_HOME needs to point to OpenJDK fix(spark): Refactor for Spark Connect Mar 25, 2025
@razvan razvan marked this pull request as ready for review March 25, 2025 12:51
@razvan razvan changed the title fix(spark): Refactor for Spark Connect fix(spark-k8s): Refactor for Spark Connect Mar 25, 2025
@razvan razvan changed the title fix(spark-k8s): Refactor for Spark Connect fix(spark-k8s): refactor for Spark Connect Mar 25, 2025
@razvan razvan requested a review from a team March 25, 2025 12:52
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Mar 25, 2025
@razvan razvan enabled auto-merge March 25, 2025 13:13
@razvan
Copy link
Member Author

razvan commented Mar 25, 2025

🟢

--- PASS: kuttl (3640.17s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/overrides_openshift-false_spark-3.5.5 (231.64s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-false_spark-3.5.5_ny-tlc-report-0.2.0 (186.31s)
        --- PASS: kuttl/harness/spark-connect_openshift-false_spark-connect-3.5.5_spark-connect-client-3.5.5_s3-use-tls-true (72.91s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-false_spark-3.5.5 (144.68s)
        --- PASS: kuttl/harness/hbase-connector_openshift-false_spark-3.5.5_hbase-2.4.18_hdfs-latest-3.4.0_zookeeper-latest-3.9.2 (966.25s)
        --- PASS: kuttl/harness/delta-lake_openshift-false_spark-delta-lake-3.5.5_delta-3.1.0 (271.14s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-false_spark-3.5.5 (129.28s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-3.5.5_s3-use-tls-true (168.54s)
        --- PASS: kuttl/harness/resources_openshift-false_spark-3.5.5 (124.23s)
        --- PASS: kuttl/harness/logging_openshift-false_spark-3.5.5_ny-tlc-report-0.2.0 (408.00s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-false_spark-3.5.5_s3-use-tls-true (169.28s)
        --- PASS: kuttl/harness/iceberg_openshift-false_spark-3.5.5 (84.82s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-false_spark-3.5.5 (142.96s)
        --- PASS: kuttl/harness/spark-examples_openshift-false_spark-3.5.5 (64.67s)
        --- PASS: kuttl/harness/custom-log-directory_openshift-false_spark-3.5.5_hdfs-latest-3.4.0_zookeeper-latest-3.9.2 (227.65s)
        --- PASS: kuttl/harness/spark-history-server_openshift-false_spark-3.5.5_s3-use-tls-true (247.80s)
PASS
 

@maltesander maltesander self-requested a review March 28, 2025 13:55
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 28, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

--- PASS: kuttl (193.02s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-3.5.5_s3-use-tls-false (192.53s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-3.5.5_s3-use-tls-true (193.02s)

@razvan razvan added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 828fcad Mar 28, 2025
3 checks passed
@razvan razvan deleted the fix/spark-env branch March 28, 2025 15:49
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 31, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 31, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants