Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interu): Add --check-test-definitions flag #30

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jan 13, 2025

Part of stackabletech/issues#659

This adds the --check-test-definitions flag which validates that the test or test-suite is defined in the tests/test-definition.yaml file. The default file path can be overridden by using --test-definitions.

NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 13, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion

tools/interu/src/cli.rs Outdated Show resolved Hide resolved
tools/interu/src/config/profile.rs Outdated Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 13, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi changed the title feat(interu): Add --check-test-options flag feat(interu): Add --check-test-definitions flag Jan 14, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 0dce603 into main Jan 14, 2025
3 checks passed
@Techassi Techassi deleted the feat/run-integration-test-check-test-options branch January 14, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

2 participants