Raw SQL query for fetching users #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
@ellipsis-dev wdyt |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b06fabf in 1 minute and 13 seconds
More details
- Looked at
688lines of code in10files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. apps/backend/src/prisma-client.tsx:74
- Draft comment:
Consider checking ifrow_to_jsonis necessary here, as the data might already be in JSON format. This could potentially simplify the query. - Reason this comment was not posted:
Confidence changes required:30%
The use ofPrisma.sqlandPrisma.rawin therawQueryArrayfunction is correct, but the use ofrow_to_jsonmight not be necessary if the data is already in JSON format. However, this is not a critical issue.
2. apps/backend/src/app/api/v1/users/crud.tsx:238
- Draft comment:
Consider adding additional error handling or validation to ensure that the query results are as expected, especially when dealing with complex JSON structures. - Reason this comment was not posted:
Confidence changes required:40%
ThegetUserQueryfunction constructs a raw SQL query using Prisma's SQL template literals. The use ofjsonb_build_objectandto_jsonbis appropriate for constructing JSON objects from SQL query results. However, the function could benefit from additional error handling or validation to ensure that the query results are as expected.
3. apps/backend/src/app/api/v1/users/crud.tsx:209
- Draft comment:
Using a fallback value of 0 might not be appropriate. Consider using a more meaningful default value or handling the case where no events are found more explicitly. - Reason this comment was not posted:
Confidence changes required:50%
ThegetUserLastActiveAtMillisfunction uses a fallback value of 0, which might not be appropriate for all use cases. It would be better to use a more meaningful default value or handle the case where no events are found more explicitly.
4. apps/backend/src/prisma-client.tsx:56
- Draft comment:
Consider adding additional type safety checks to ensure that all queries are valid before execution. This can help prevent runtime errors. - Reason this comment was not posted:
Confidence changes required:30%
TherawQueryAllfunction filters out undefined queries usingisNotNull, which is a good practice. However, the function could benefit from additional type safety checks to ensure that all queries are valid before execution.
Workflow ID: wflow_EYa54591KLvRVWFZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| isAdminKeyValid: projectId && superSecretAdminKey && requestType === "admin" ? checkApiKeySetQuery(projectId, { superSecretAdminKey }) : undefined, | ||
| }; | ||
| const queriesResults = await rawQueryAll(bundledQueries); | ||
| console.log("AAAAAAAAA", queriesResults, bundledQueries); |
There was a problem hiding this comment.
Remove the console.log statement to avoid unnecessary logging in production.
jshimko
added a commit
to jshimko/stack
that referenced
this pull request
Dec 28, 2024
* dev: (138 commits) Raw project query (stack-auth#382) Require pagination cursor to be UUID Fix unit tests Fix users query Log error when selected team member has no team chore: update package versions Raw SQL query for fetching users (stack-auth#381) Better 429 request logging Fix STACK-SERVER-NH Only fetch keys that are required for the access type Improved OTel spans Better traceSpan signature Even more OTel spans Add display name to span attributes More OTel spans Update backend TypeScript target chore: update package versions removed GET team transaction fixed smtp config bug Insert final newline on file save ... # Conflicts: # .github/workflows/docker-build.yaml # apps/backend/package.json # apps/backend/prisma/seed.ts # apps/backend/sentry.client.config.ts # apps/backend/src/polyfills.tsx # apps/dashboard/sentry.client.config.ts # apps/dashboard/src/app/(main)/(protected)/(outside-dashboard)/projects/page-client.tsx # apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx # apps/dashboard/src/components/data-table/user-table.tsx # apps/dashboard/src/components/version-alerter.tsx # apps/dashboard/src/polyfills.tsx # examples/cjs-test/package.json # examples/demo/src/app/page-client.tsx # examples/middleware/package.json # examples/partial-prerendering/package.json # package.json # packages/stack/package.json # packages/stack/src/generated/quetzal-translations.ts # packages/stack/src/lib/stack-app.ts # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces raw SQL queries for efficient user data fetching, optimizing backend query execution in
crud.tsxandprisma-client.tsx.getUserQueryincrud.tsxfor raw SQL user fetching.getUserto userawQueryfor optimized data retrieval.rawQueryAllinprisma-client.tsxfor batch query execution.getUserLastActiveAtMillisto includeprojectIdparameter.getUsersLastActiveAtMillisto use raw SQL for efficiency.isNotNullutility function inobjects.tsx.defaults.jsto includeTemplateLiteral *in ignored nodes.This description was created by
for 1a0afff. It will automatically update as commits are pushed.