pass auth_config through to ContentFetcherTask #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it possible to pass API headers to pystac_client
|
Hi @hrodmn, thanks so much for your contribution. It would have been nice to have support for all available QGIS authentication methods, but it is great to see you have at least covered one of them. |
|
@Samweli I modified the run_tests.sh script a little bit and ran the tests on all of the versions that run in this package's CI: #!/usr/bin/env bash
QGIS_IMAGE=qgis/qgis
QGIS_IMAGE_V_3_16=release-3_16
QGIS_IMAGE_V_3_20=release-3_20
QGIS_IMAGE_V_3_22=release-3_22
QGIS_IMAGE_V_3_24=release-3_24
QGIS_IMAGE_V_3_26=final-3_26_0
QGIS_VERSION_TAGS=($QGIS_IMAGE_V_3_16 $QGIS_IMAGE_V_3_20 $QGIS_IMAGE_V_3_22 $QGIS_IMAGE_V_3_24 $QGIS_IMAGE_V_3_26)
export IMAGE=$QGIS_IMAGE
export WITH_PYTHON_PEP=false
export ON_TRAVIS=false
export MUTE_LOGS=true
for TAG in "${QGIS_VERSION_TAGS[@]}"
do
echo "Running tests for QGIS $TAG"
export QGIS_VERSION_TAG=$TAG
docker compose up -d
sleep 10
docker compose exec -T qgis-testing-environment sh -c "pip3 install flask"
docker compose exec -T qgis-testing-environment qgis_testrunner.sh test_suite.test_package
docker compose down
doneThe tests pass for all of the versions except 3.22, but this may be expected because apparently that image was pushed from a failed build! See qgis/QGIS#50729 for details. Here is the test output: |
|
Sounds good, @Samweli. I want to add a unit test case with a mock server that requires authentication. I am trying to work out a solution there but need to get up to speed on flask. Based on this post it looks like it shouldn't be too hard to mock up a header-based authentication scheme: https://blog.ruanbekker.com/blog/2018/06/01/add-a-authentication-header-to-your-python-flask-app/ |
|
Hello, is there any plan on when this will be merged to a new release of the plugin? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to pass API headers from a
QgsAuthMethodConfigtopystac_client.Client.open. To do this right we would definitely want a more thorough treatment of alternative authentication options but I just want to put it out here for others to look at.This resolves #206 and starts us on the path towards #207 .