Remove default limit

[gadomski]

Related Issue(s):

• pystac-client's default limit was causing too-large responses in Earth Search: Ambiguous error message when the response is too large for a lambda Element84/earth-search#17 (comment)

Description:

We should trust the server to know how many things it wants to respond with. Tagging in a couple of folks for reviews since this is changing default behavior. I don't think this is worth marking as a breaking change (thereby forcing a v0.8), but happy to be convinced otherwise.

PR Checklist:

• Code is formatted
• Tests pass
• Changes are added to the CHANGELOG

[jsignell]

Yeah I like this. That limit always seemed weird to me

[codecov-commenter]

Codecov Report

Patch coverage is 60.00% of modified lines.

Files Changed	Coverage
pystac_client/client.py	ø
pystac_client/item_search.py	60.00%

📢 Thoughts on this report? Let us know!.

[TomAugspurger]

@gadomski can you share a bit more (here or in the docs) about how this changes the behavior (maybe depending on how the sever is behaving w.r.t. limit)?

We should trust the server to know how many things it wants to respond with.

Is that part of the response body to /search, or just some configuration value on the server?

[gadomski]

@gadomski can you share a bit more (here or in the docs) about how this changes the behavior (maybe depending on how the sever is behaving w.r.t. limit)?

Sure ... this PR changes behavior so that pystac-client, by default, does not send a limit to the search endpoint. The rationale is that the server (presumably) has been tuned to use a reasonable page size by default, and the client shouldn't presume to know better.

Is that part of the response body to /search, or just some configuration value on the server?

Configuration in the server, e.g. for stac-fastapi it's 10: https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/types/stac_fastapi/types/search.py#L125

[TomAugspurger]

Ok, thanks. Looks like on the Planetary Computer, we have it set to 250:

❯ curl --silent "https://planetarycomputer.microsoft.com/api/stac/v1/search" | jq '.features | length'
250

Following the guidance of the server (by default) makes sense to me.