Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix development environment #129

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

kkulak
Copy link
Contributor

@kkulak kkulak commented Dec 18, 2024

Description

If you clone a fresh repository, you cannot make it work locally as it will end up with several problems, one of them has already been described.

The solution is to update the dependencies in the Makefile. CRD definition seems to have many changes, but in fact, this is just description reformatting. I had to drop CRD_OPTIONS as they are no longer supported in controller-gen anymore.

CC @kane8n

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Related issues:

Copy link
Contributor

@kane8n kane8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks! @kkulak 🏆

@kane8n kane8n merged commit 50c1af4 into st-tech:main Dec 23, 2024
3 checks passed
@kkulak kkulak mentioned this pull request Dec 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants