-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append the crumb to the URL (Fix #206, #209, #211 and #225) #210
base: develop
Are you sure you want to change the base?
Conversation
Hi @gilbertoca , are you sure that this change alone fixes the problem? At least, I had to also change the cookie retrieval mechanism: v3rtumnus@a961b19 |
@v3rtumnus Yes!
|
Ah this could actually explain it because I am from the EU and had problems with the cookie consent banner (maybe this one is not shown when visiting Yahoo outside of EU) |
I am trying to access the historical data and getting this error, I am at Polish Region(EU) too |
still got an error "Server returned HTTP response code: 429 for URL: https://query1.finance.yahoo.com/v1/test/getcrumb" |
Just as a side note, by accident I discovered today that with Java 21 I got 404 (or 401, don't remember) but Java 1.8 worked fine. Maybe Java 21 doesn't allow you to override the user agent and Yahoo picks up on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change B=.*
in line 56 to A1S=.*
, that worked for me.
Thank you @bnsd55 ! On my side, I was getting this exception Caused by: java.io.IOException: Server returned HTTP response code: 503 for URL: https://finance.yahoo.com/quote/%5EGSPC/options |
@sstrickx could you pls approve and merge, we need this release |
@gilbertoca this ain't working, try running this test in your local public class CrumbManagerTest {
@Test
public void testGetCrumb() throws IOException {
assertNotNull(CrumbManager.getCrumb());
}
} |
@foxhound91, it is working locally |
add simply tests to CrumbManager and QuoteRequestTest
append the crumb to the URL
Fix #206, #209, #211 and #225