Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vulnerable path-to-regexp dependency #509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nhardy
Copy link

@nhardy nhardy commented Sep 11, 2024

Updates path-to-regexp to resolve GHSA-9wv6-86v2-598j

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 91e186d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 1:07am

Copy link
Collaborator

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -45,7 +45,7 @@
"aws4fetch": "^1.0.18",
"chalk": "^5.3.0",
"esbuild": "0.19.2",
"path-to-regexp": "^6.2.1",
"path-to-regexp": "^8.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this ? Jumping 2 major version and being out of sync with nextjs itself ( they are still on 6.1 ) will probably cause some trouble.
6.3.0 also include the fix without any breaking change, that's probably what we want to use

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time I raised this PR, only v8 had patched the issue, and v6 was still vulnerable. I had been using this with npm overrides without issue.

Given that a patch now exists for v6, I can revert back to v6 if that improves confidence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's probably better, there might be some edge case that are broken and it will be a pain to debug later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhardy Could you make this change please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants