enableLegacyUriCompliance() should not be deprecated

The Jetty team has said that this will be supported in the future
ssheikin · Jun 18, 2024 · 24d6b27 · 24d6b27
1 parent 6da6490
commit 24d6b27
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/CHANGES b/CHANGES
@@ -11,6 +11,7 @@
 - Add HTTP protocol version to client traces
 - Improve request/response metrics accuracy and correctness
 - Update Airbase to 157
+- Remove deprecation notices/annotations from `enableLegacyUriCompliance()`
 
 248
 

diff --git a/http-server/src/main/java/io/airlift/http/server/HttpServerBinder.java b/http-server/src/main/java/io/airlift/http/server/HttpServerBinder.java
@@ -47,10 +47,6 @@ public HttpServerBinder enableCaseSensitiveHeaderCache()
         return this;
     }
 
-    /**
-     * @deprecated this will be removed in the near future and is only intended as a stopgap
-     */
-    @Deprecated(forRemoval = true)
     public HttpServerBinder enableLegacyUriCompliance()
     {
         newOptionalBinder(binder, Key.get(Boolean.class, EnableLegacyUriCompliance.class)).setBinding().toInstance(true);

diff --git a/http-server/src/test/java/io/airlift/http/server/TestHttpServerModule.java b/http-server/src/test/java/io/airlift/http/server/TestHttpServerModule.java
@@ -178,7 +178,6 @@ public static Iterator<Boolean> enabledDisabled()
         return ImmutableList.of(true, false).iterator();
     }
 
-    @SuppressWarnings("removal")
     @Test(dataProvider = "enabledDisabled")
     public void testServer(boolean enableLegacyUriCompliance)
             throws Exception

diff --git a/jaxrs/src/test/java/io/airlift/jaxrs/TestLegacyUriMode.java b/jaxrs/src/test/java/io/airlift/jaxrs/TestLegacyUriMode.java
@@ -95,7 +95,6 @@ private void doTest(boolean legacyUriComplianceEnabled, Tester... testers)
         }
     }
 
-    @SuppressWarnings("removal")
     private Injector startServer(boolean legacyUriComplianceEnabled)
     {
         return new Bootstrap(
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
-        @SuppressWarnings("removal")
         private Injector startServer(boolean legacyUriComplianceEnabled)
         {
             return new Bootstrap(
@@ Expand Down @@