Skip to content

Commit

Permalink
fix: correctly place connaisseur-env-secret in deployment yaml
Browse files Browse the repository at this point in the history
From chart version 2.4, a refactor was made that places connaisseur-env-secret under 'env' instead of under 'envFrom' in the deployment.This breaks cosign validations that require custom secrets like ECR
  • Loading branch information
edison-vflow authored and phbelitz committed Aug 23, 2024
1 parent f1e02d1 commit e06a432
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions charts/connaisseur/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ spec:
- secretRef:
name: {{ include "connaisseur.redisSecret" . }}
{{- end }}
env:
{{ if gt (dig "features" "cache" "expirySeconds" 30 .Values.application | int) 0 -}}
- name: REDIS_HOST
value: {{ include "connaisseur.redisService" . }}
{{- end }}
{{ if .Values.kubernetes.deployment.envs -}}
- secretRef:
name: {{ include "connaisseur.envSecretName" . }}
{{- end }}
env:
{{ if gt (dig "features" "cache" "expirySeconds" 30 .Values.application | int) 0 -}}
- name: REDIS_HOST
value: {{ include "connaisseur.redisService" . }}
{{- end }}
volumes:
- name: certs
secret:
Expand Down

0 comments on commit e06a432

Please sign in to comment.