-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make user registration work #37
Conversation
…y-frontend-prototype into make-user-registration-work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I register, but then navigate away from the second form before submitting it, I am not a user but I can somehow log in.. maybe it would be simpler to have atomic user creation, where the first form is enough to make a user, then the second form just optionally updates the logged-in users's additional info.
Also the additional logic to make a unique new userid is not going to be used in reality, so maybe simpler to not do it?
Finally it would be better not to expose the password in plain text anywhere, even though the website is fake, people might enter a real username & password.
Otherwise looks good!
9336b8f
to
05978c5
Compare
temp variables for storing user credentials are still there, however. Will be gotten rid of in one of the following PRs that componentizes the input forms again, or at the latest when the backend will be written. |
@lkeegan you want to have a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
AbstractDropdownItem
intoSelect
in analogy toInput
.Input
toSelect
(Validation, arguments).toBeRegistered