Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user registration work #37

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Make user registration work #37

merged 14 commits into from
Sep 9, 2024

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Sep 5, 2024

  • rename AbstractDropdownItem into Select in analogy to Input.
  • add elements from Input to Select (Validation, arguments).
  • user registration has 2 parts
  • primary registration: username + email + password
  • these data are saved in a temporary element of the userstore toBeRegistered
  • if accepted, get to the next page where you have to put in some personal data for data analysis
  • if accepted, user gets added to current userstore and childrenstore
  • if not, error messages are given in alert section at the top and elements are highlighted
  • newly registered user is set to be logged in right afterwards
  • simple attempt at error handling: try-catch --> if error: show alert message in banner
  • no further componentization for now.

@MaHaWo MaHaWo requested a review from lkeegan September 5, 2024 13:38
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I register, but then navigate away from the second form before submitting it, I am not a user but I can somehow log in.. maybe it would be simpler to have atomic user creation, where the first form is enough to make a user, then the second form just optionally updates the logged-in users's additional info.

Also the additional logic to make a unique new userid is not going to be used in reality, so maybe simpler to not do it?

Finally it would be better not to expose the password in plain text anywhere, even though the website is fake, people might enter a real username & password.

Otherwise looks good!

@MaHaWo MaHaWo force-pushed the make-user-registration-work branch from 9336b8f to 05978c5 Compare September 6, 2024 08:31
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Sep 6, 2024

  • remove logic for user duplication
  • fix bug by making registration effective immediatelly
  • make password into hashvalue

temp variables for storing user credentials are still there, however. Will be gotten rid of in one of the following PRs that componentizes the input forms again, or at the latest when the backend will be written.

@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Sep 6, 2024

@lkeegan you want to have a look again?

@MaHaWo MaHaWo linked an issue Sep 6, 2024 that may be closed by this pull request
7 tasks
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lkeegan lkeegan merged commit c87f299 into main Sep 9, 2024
3 checks passed
@lkeegan lkeegan deleted the make-user-registration-work branch September 9, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta] make user registration fully functional
2 participants