Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework feedback page #232

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Rework feedback page #232

wants to merge 14 commits into from

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Mar 5, 2025

  • we need to add the title;
  • the description should be changed as in the example (volume reduction);
  • all texts (descriptions, details under the button and legend) need to match the latest version of the client (I'll attach it below);
  • the legend should stay open all the time without wrapping (we can reduce the scrolling time with a shorter description);
  • get rid of the buttons "Feedback zu vorherigen Beobachtungszeiträumen anzeigen", "Mehr Informationen zur Erstellung der Bewertung" and blue arrows around the previous periods. It can just be there all the time;
  • add the button "Mehr Info zur Bewertung" at the same level as the second title (I'll attach the new text of it below);
  • the customer's request is that the primary color (blue) be used only for milestones. The accordion headers need to be blue. For other elements on the site we can use the "additional-color" options. They are already added to tailwind.config.ts;
  • the feedback for the overall score should be presented before the Individual development areas;
  • can we have 3 or 2 columns of milestone groups on wide screens;
  • The user should only be able to see the problematic milestones under a milestones group (green ones should be invisible). The background of a problematic milestone on opening is (yellow) color #f3ddb0.

closes #227

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 121 lines in your changes missing coverage. Please review.

Project coverage is 29.77%. Comparing base (da3434f) to head (6add1f0).

Files with missing lines Patch % Lines
...rontend/src/lib/components/ChildrenFeedback.svelte 0.00% 107 Missing ⚠️
frontend/src/lib/translations.ts 0.00% 12 Missing ⚠️
frontend/tailwind.config.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   29.72%   29.77%   +0.04%     
==========================================
  Files         115      115              
  Lines        4508     4501       -7     
  Branches      100      100              
==========================================
  Hits         1340     1340              
+ Misses       3084     3077       -7     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaHaWo MaHaWo requested a review from Majapur1 March 6, 2025 16:21
Copy link

sonarqubecloud bot commented Mar 6, 2025

@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Mar 6, 2025

@Majapur1
in the vid below you can see the current version of the feedback page this branch implements, in case you can´t get it to work locally:

feedback_page.webm

there are only 2 milestonegroups since I didn´t add more to my local database (lot of work to do that)

On mobile, it currently looks like this:

feedback_page_mobile.mp4

@MaHaWo MaHaWo requested a review from lkeegan March 6, 2025 16:26
@Majapur1
Copy link
Collaborator

Majapur1 commented Mar 7, 2025

@MaHaWo It looks good, thanks for the videos!

Regarding your reasonable question about the yellow milestones under the green groups — I have an answer. We need to add information (a line of text) about this particular possibility to inform users. I will get back to you with ideas on where to place it and some comments on the latest version of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New client suggestions on the feedback page
3 participants