Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check failure when there is a wild card CNAME record #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix check failure when there is a wild card CNAME record #668

wants to merge 1 commit into from

Commits on Jun 21, 2021

  1. Fix check failure when there is a wild card CNAME record 

    If there is a wildcard CNAME record "*.domain.com", resolving `_acme-challenge.domain.com` would yield another domain. Getssl incorrectly updates the check domain with the resolved domain which causes check failure! 

Let's Encrypt validation does not follow CNAME of the challenge domain and Getssl should not too.
    @alhashash
    alhashash authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d15f4dc View commit details
    Browse the repository at this point in the history