Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with *() patterns if extglob is on. #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion getssl
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,11 @@
# 2020-02-13 Fix bug with copying to all locations when creating RSA and ECDSA certs (2.20)
# 2020-02-22 Change sign_string to use openssl asn1parse (better fix for #424)
# 2020-02-23 Add dig to config check for systems without drill (ubuntu)
# 2020-03-03 Fix a *() pattern bug with ACMEv2 when extglob is on in send_signed_request (2.20.1)
# ----------------------------------------------------------------------------------------

PROGNAME=${0##*/}
VERSION="2.20"
VERSION="2.20.1"

# defaults
ACCOUNT_KEY_LENGTH=4096
Expand Down Expand Up @@ -1707,6 +1708,9 @@ send_signed_request() { # Sends a request to the ACME server, signed with your p
fi

nonceproblem="true"
# Avoid problems with *() patterns in variable substition
trap "$(shopt -p extglob)" RETURN
shopt -u extglob
while [[ "$nonceproblem" == "true" ]]; do

# Build header with just our public key and algorithm information
Expand Down