Qos patch and fixes #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hudouseko! Thanks for this MR - much appreciated. We are currently a little behind with the public version of the Helm charts. We will push a minor update that includes some of the fixes that you have pushed already. Once this is online we can merge your MR. I will take care of this as soon as the public repo is update to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have consolidated fixes for the 3 issues I have raised: #3 #4 and #5 . On top of that I have extended charts (deployment.yaml as well as values.yaml) with qos (5QI) configuration, which was not present before. Ill be happy if you consider taking fixes and/or extension into the project.