Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srsran-project values.yaml: vlan_tag substituted by vlan_tag_cp and vlan_tag_up #5

Open
hudouseko opened this issue Sep 11, 2024 · 0 comments
Assignees

Comments

@hudouseko
Copy link

Hi,
I came across a minor issue, values.yaml default value for OFH VLAN is defined using vlan_tag:

    cells:
    - network_interface: enp1s0f0                                 # Ethernet interface name used to communicate with the RU.
      ru_mac_addr: 70:b3:d5:e1:5b:06                              # RU MAC address.
      du_mac_addr: 80:61:5f:0d:df:aa                              # DU MAC address.
      vlan_tag: 5

Nevertheless currently (as per SRSRAN configuration ) VLAN on OFH is defined using vlan_tag_cp and vlan_tag_up, not vlan_tag (which was used earlier). This is already correctly handled in configmap.yml:

        {{- if .vlan_tag_up }}
        vlan_tag_up: {{ .vlan_tag_up }}
        {{- end }}
        {{- if .vlan_tag_cp }}
        vlan_tag_cp: {{ .vlan_tag_cp }}
        {{- end }}

Would be great to fix it in values.yml as well, but as a default is inbuilt in srs gnb itself and would be anyway typically overridden by local values.yml, I see this as quite minor issue.

hudouseko added a commit to hudouseko/srsRAN_Project_helm that referenced this issue Sep 12, 2024
Default value for OFH VLAN was set as vlan_tag, while currently vlan_tag_cp and vlan_tag_up are used, see srsran#5
@ninjab3s ninjab3s self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants