Add pcap over net support for ue #733
Conversation
|
Thanks @matan1008 for the contribution. Unfortunately we didn't have the bandwidth to review and integrate this before the 21.10 release. However, I encourage you to rebase the branch again on current |
matan1008
force-pushed
the
feature/pcap-net-ue
branch
from
69b8d9c
to
c4b1ee5
Compare
| @@ -18,6 +18,8 @@ | |||
| # and at http://www.gnu.org/licenses/. | |||
| # | |||
|
|
|||
| find_package(SCTP REQUIRED) | |||
There was a problem hiding this comment.
why is this needed for the UE?
There was a problem hiding this comment.
I don't really know why it is required (maybe to send the capture over the network?) but without linking with SCTP the build fails with:
[ 78%] Linking CXX executable srsue
/usr/bin/ld: ../../lib/src/common/libsrsran_common.a(network_utils.cc.o): in function `srsran::task_details::heap_table_t<srsran::sctp_recvmsg_pdu_task, bool, int>::call(void*, int) const':
network_utils.cc:(.text._ZNK6srsran12task_details12heap_table_tINS_21sctp_recvmsg_pdu_taskEbJiEE4callEPvi[_ZNK6srsran12task_details12heap_table_tINS_21sctp_recvmsg_pdu_taskEbJiEE4callEPvi]+0xe6): undefined reference to `sctp_recvmsg'
collect2: error: ld returned 1 exit status
make[2]: *** [srsue/src/CMakeFiles/srsue.dir/build.make:181: srsue/src/srsue] Error 1
make[1]: *** [CMakeFiles/Makefile2:10845: srsue/src/CMakeFiles/srsue.dir/all] Error 2
make: *** [Makefile:163: all] Error 2There was a problem hiding this comment.
Mhh, maybe the network utils need to be stripped to have a version without SCTP that can be used in srsUE. I have to say that we are reluctant to do this change now. I'd leave the PR open in case it's useful for others like it is.
| @@ -43,7 +43,8 @@ target_link_libraries(srsue ${SRSUE_SOURCES} | |||
| ${SRSRAN_SOURCES} | |||
| ${CMAKE_THREAD_LIBS_INIT} | |||
| ${Boost_LIBRARIES} | |||
| ${ATOMIC_LIBS}) | |||
| ${ATOMIC_LIBS} | |||
| ${SCTP_LIBRARIES}) | |||
There was a problem hiding this comment.
this shouldn't be needed for the UE
matan1008
force-pushed
the
feature/pcap-net-ue
branch
from
c4b1ee5
to
ecc7666
Compare
|
|
matan1008
force-pushed
the
feature/pcap-net-ue
branch
from
ecc7666
to
21eca90
Compare
Tested over zmq.
Thanks a lot!