Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create labdir next to clab file #2394

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Create labdir next to clab file #2394

merged 7 commits into from
Jan 14, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 14, 2025

no one will miss the old behavior of creating the labdir in the $pwd

@hellt hellt merged commit 5132320 into main Jan 14, 2025
67 checks passed
@hellt hellt deleted the labdir-where-topofile branch January 14, 2025 21:55
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (bf7e377) to head (a1cf01d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   51.88%   51.95%   +0.06%     
==========================================
  Files         172      172              
  Lines       17302    17300       -2     
==========================================
+ Hits         8978     8988      +10     
+ Misses       7381     7373       -8     
+ Partials      943      939       -4     
Files with missing lines Coverage Δ
clab/config.go 67.69% <100.00%> (ø)
types/topo_paths.go 74.13% <100.00%> (+2.10%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant