Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression for docker bridge gw check on darwin dind #2364

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

carlmontanari
Copy link
Contributor

little regression after #1482 -- pretty much same issue where clab cant find gw for the bridge (via netlink) and stops even though we have that data from docker inspection.

@hellt hellt merged commit 34cb5d0 into main Dec 30, 2024
66 of 67 checks passed
@hellt hellt deleted the fix/dind-darwin branch December 30, 2024 10:52
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.79%. Comparing base (2a5343e) to head (01859ff).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
runtime/docker/docker.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
- Coverage   51.80%   51.79%   -0.01%     
==========================================
  Files         172      172              
  Lines       17240    17243       +3     
==========================================
  Hits         8931     8931              
- Misses       7369     7371       +2     
- Partials      940      941       +1     
Files with missing lines Coverage Δ
runtime/docker/docker.go 68.67% <25.00%> (-0.26%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants