Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker go sdk for clab-io-draw #2363

Merged
merged 2 commits into from
Dec 30, 2024
Merged

docker go sdk for clab-io-draw #2363

merged 2 commits into from
Dec 30, 2024

Conversation

FloSch62
Copy link
Member

This closes #2361

Using docker go sdk
Fix smoke test for drawio generation.

@FloSch62 FloSch62 requested a review from hellt December 24, 2024 10:45
@FloSch62
Copy link
Member Author

I was thinking to use the implemations from runtime/docker, but I was not able to use them, so I implemented the docker client in graph.go . It's a bit weird to have func forcePull in graph.go, but thats my current limit of my go skills...

@hellt hellt merged commit 998a9e1 into srl-labs:main Dec 30, 2024
66 of 67 checks passed
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 44.97041% with 93 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (0077e9f) to head (d6d6de4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
clab/graph.go 44.97% 77 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
- Coverage   51.88%   51.76%   -0.12%     
==========================================
  Files         172      172              
  Lines       17136    17240     +104     
==========================================
+ Hits         8891     8925      +34     
- Misses       7318     7374      +56     
- Partials      927      941      +14     
Files with missing lines Coverage Δ
clab/graph.go 21.98% <44.97%> (+7.48%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph.go GenerateDrawioDiagram
2 participants