Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support healthchecks configuration for nodes #1426

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jun 7, 2023

implementing #1421 for podman and docker. containerd does not support healthchecks

  • Docs are missing (@hellt can you cover that?!)
  • schema should be double checked.

@steiler steiler added the enhancement New feature or request label Aug 14, 2023
@steiler steiler requested a review from hellt October 25, 2023 08:52
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ce1f20c) 48.48% compared to head (684b3c5) 50.36%.

❗ Current head 684b3c5 differs from pull request most recent head 7697eac. Consider uploading reports for the commit 7697eac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   48.48%   50.36%   +1.88%     
==========================================
  Files         147      147              
  Lines       14230    14271      +41     
==========================================
+ Hits         6899     7188     +289     
+ Misses       6560     6299     -261     
- Partials      771      784      +13     
Files Coverage Δ
clab/config.go 67.41% <100.00%> (+0.83%) ⬆️
runtime/docker/docker.go 67.77% <100.00%> (+0.43%) ⬆️
types/node_definition.go 95.00% <100.00%> (+0.10%) ⬆️
types/types.go 64.86% <100.00%> (+4.86%) ⬆️
types/topology.go 67.97% <66.66%> (-0.04%) ⬇️
runtime/podman/util.go 56.59% <12.50%> (+41.71%) ⬆️

... and 10 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented Dec 21, 2023

thanks @steiler
docs and schema fixed/added.

@hellt hellt changed the title support healthchecks support healthchecks configuration for nodes Dec 21, 2023
@hellt hellt merged commit 841431c into srl-labs:main Dec 21, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants